search

arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments
MIT License
189 stars 57 forks source link

Add webrick as a dependency for Ruby 3 #56

Closed matthieu-foucault closed 2 years ago

matthieu-foucault commented 3 years ago

As of Ruby 3.0.0, webrick is no longer part of the standard library: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/

The default server for this project is webrick, so it should be added as a dependency in the gemspec file

BrianSigafoos commented 3 years ago

Or please at least add a note for Ruby 3.0+ to add webrick as a dependency OR change the config's default to puma, etc. 🙏

arturictus commented 2 years ago

Hi @matthieu-foucault, thanks for pointing out this issue. This #51 solves this and it is released at 2.1.4.s

Hi @BrianSigafoos, You have a config to change the server, I'm happy to accept PRs or discussions to move to puma.