arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments
MIT License
189 stars 57 forks source link

Remove deprecated options call on config #67

Closed andrcuns closed 1 year ago

andrcuns commented 1 year ago

Usage of config.options[:key] = value is deprecated and generates

kleinjm commented 1 year ago

+1 would love to get rid of this deprecation warning

arturictus commented 1 year ago

Hi @andrcuns , Thanks for your PR :)

I can not merge how it is right now. There are tests failing (sorry I did not manage to run actions for this PR) and it will break backward compatibility.

What I think a way to go could be:

let me know what you thing

andrcuns commented 1 year ago

@arturictus Yeah, definitely. I forgot about it but then added in my own fork because I was not sure how fast anything would get merged here.

Though it will be quite hard to maintain backwards compatibility with sidekiq 7, because it adds quite a bit of breaking changes.

I will add check for options.

DorianSwile commented 1 year ago

Hi, Thanks @andrcuns for the fix, this is very useful and mandatory ! I'm trying to bump this PR up, cc @arturictus

arturictus commented 1 year ago

Thanks @andrcuns! releasing new version today

arturictus commented 1 year ago

sidekiq_alive 2.1.6 released! 🚀