search

arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments
MIT License
188 stars 57 forks source link

Fix version update task #78

Closed andrcuns closed 1 year ago

andrcuns commented 1 year ago

Because Gemfile.lock is ignored to allow testing with multiple versions of sidekiq, there is no need to update and commit it during version updates.

andrcuns commented 1 year ago

@arturictus Could You please review? It should fix the version update job.

I also deleted the release and tag since we haven't actually released a new version of the gem because the update job failed

arturictus commented 1 year ago

@andrcuns perfect!, you read my mind I wanted to fix this

andrcuns commented 1 year ago

@arturictus

It looks like it works 🥳 https://github.com/arturictus/sidekiq_alive/actions/runs/3801818585/jobs/6466690741

FYI, release needs not to be created manually, that job would push the tag automatically which would trigger the Changelog action which should create release with the changelog data