Run redis calls inside block

arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments

MIT License

188 stars 57 forks source link

Run redis calls inside block #91

Closed arturictus closed 1 year ago

arturictus commented 1 year ago

related to #89

github-actions[bot] commented 1 year ago

Package	Line Rate	Health
sidekiq_alive	93%	✔
Summary	93% (386 / 413)	✔

Minimum allowed line rate is 50%

fwolfst commented 1 year ago

Who would typically do reviews in this project? To me it looks fine, but unfortunately I cannot test on the infrastructure where we noticed the original log messages.

michael-ujet commented 1 year ago

for what it's worth, we were seeing issues where the web requests (GET localhost:7433) would frequently and intermittently take over 1 second while normally they take about a millisecond (on 2.2.1 with sidekiq 7.0.9). That cleared up using this specific branch. would love to see this get in.

arturictus commented 1 year ago

@fwolfst , @michael-ujet , released in version 2.2.2