arturkowalczyk300 / android-cryptocurrency-prices

Application for displaying prices of cryptocurrencies on chart, in specified date range. Readings are stored in local database.
Apache License 2.0
4 stars 1 forks source link

Versioning #19

Open IzzySoft opened 1 year ago

IzzySoft commented 1 year ago

Could you please take care for proper versioning of the app? Currently, all versions identify as

package: name='com.arturkowalczyk300.cryptocurrencyprices' versionCode='1' versionName='1.0'

This not only makes them hard to tell apart, but also complicates automatic updates.

Thanks in advance for considering!

IzzySoft commented 1 year ago

PS: I also wonder what license your app falls under. Apache-2.0, as mentioned here?

IzzySoft commented 1 year ago

Any word, @arturkowalczyk300 ?

arturkowalczyk300 commented 1 year ago

Sorry, I didn't see this issue previously. Thanks for pointing out lack of proper versioning - I fixed it in newest commit and I will keep using it in future releases.

And thing about license - I didn't think about it before, but I see that Apache-2.0 is quite libertarian license - so I can say, it is actual license of this project. Treat this software as open, feel free to re-use it.

IzzySoft commented 1 year ago

Great, thanks! Then let me propose a nice deal: I add your app to my repo now¹ – and you add the license to your repo? :smiley:

¹ Oops, need to wait for the next release, when versioning is fixed :see_no_evil: So once that's done you'll probably close this issue, which should send me a ping, and I'll then add it to my repo :smiley:

arturkowalczyk300 commented 1 year ago

Sounds perfect!

I've added license type information to the repository, also I increased version number again and this time forced to publish first app release with specified license. It's here: https://github.com/arturkowalczyk300/android-cryptocurrency-prices/releases/tag/v0.8.4

IzzySoft commented 1 year ago

Deal! Then let's do it. With the next sync around 7 pm UTC, your app should show up here. As F-Droid repos aim for maximum transparency, it currently carries two so-called anti-features, at least one of which is easy to get rid of:

To get an idea how the listing will look like, here's a screenshot from the staging area: image

Now if you wish:

Thanks a lot for the fast adjustments! If you consider everything solved, feel free to close this issue. Sending Fastlane would mean a new one (aka PR) anyway – and the related details could be discussed there.

Wjxfi commented 1 year ago

why no updates in izzyondroid f-droid repo? @IzzySoft

IzzySoft commented 1 year ago

@Wjxfi because all releases are marked pre-releases, so my updater usually skips them. Thanks for the ping; as there's no single "stable release" yet I've told my updater to not ignore them. Manually triggered an update to confirm: works, it immediately fetched v0.9.2, which will become available with the next sync around 6 pm UTC.