This PR makes IBAN random generation independent per IBAN.
This should prevent problems in the future where an IBAN Structure is modified.
Adjusting the behaviour like this is just one option to fix it, the other would be to update the tests (although I'm not sure how that can be done...).
Summary
create new instances of Randoms where necessary, so that adding/removing IBAN entries won't affect any IBANs that are subsequently generated.
update tests to use assertAll, so it's easier to check & update each value
Verification
I had a quick play around to verify it by adjusting the structure of GL and verifying only one of the ibanBuilderConstructionSeeded() tests failed. I'd appreciate it if you could take a more thorough look :)
This PR makes IBAN random generation independent per IBAN.
This should prevent problems in the future where an IBAN Structure is modified.
Adjusting the behaviour like this is just one option to fix it, the other would be to update the tests (although I'm not sure how that can be done...).
Summary
Verification
I had a quick play around to verify it by adjusting the structure of
GLand verifying only one of theibanBuilderConstructionSeeded()tests failed. I'd appreciate it if you could take a more thorough look :)Fix #91