search

arturmkrtchyan / iban4j

A Java library for generation and validation of the International Bank Account Numbers (IBAN ISO_13616) and Business Identifier Codes (BIC ISO_9362).
http://iban4j.org
Apache License 2.0
270 stars 124 forks source link

Change IBAN format for IS (Iceland) (fixes #132) #133

Closed proshin-roman closed 6 months ago

proshin-roman commented 6 months ago

The main change in this pull request is the new IBAN format for IS country code (Iceland). All the rest is more like a code clean up - I hope you don't mind. If these changes are not wanted - I can rollback them.

proshin-roman commented 6 months ago

@arturmkrtchyan could you please take a look at this pull request? Any feedback is welcome!

hajk1 commented 6 months ago

@proshin-roman I will approve your current PR. For the future please create a separate PR for the formatting and the cleanups.

proshin-roman commented 6 months ago

@hajk1 thank you for the approval! You mean two pull requests for the same issue, right? Will do that in the future 👍

hajk1 commented 6 months ago

@proshin-roman refactoring other parts of the code is a good practice and must be followed on a usual basis. However, mixing the improvements with the other fixes or features makes the review hard. So it's better to make them separate in terms of better code review and cleaner code history.