Closed proshin-roman closed 6 months ago
@arturmkrtchyan could you please take a look at this pull request? Any feedback is welcome!
@proshin-roman I will approve your current PR. For the future please create a separate PR for the formatting and the cleanups.
@hajk1 thank you for the approval! You mean two pull requests for the same issue, right? Will do that in the future 👍
@proshin-roman refactoring other parts of the code is a good practice and must be followed on a usual basis. However, mixing the improvements with the other fixes or features makes the review hard. So it's better to make them separate in terms of better code review and cleaner code history.
The main change in this pull request is the new IBAN format for IS country code (Iceland). All the rest is more like a code clean up - I hope you don't mind. If these changes are not wanted - I can rollback them.