search

arturmkrtchyan / iban4j

A Java library for generation and validation of the International Bank Account Numbers (IBAN ISO_13616) and Business Identifier Codes (BIC ISO_9362).
http://iban4j.org
Apache License 2.0
271 stars 124 forks source link

Add French sub-territories support #65

Closed remi-georges closed 2 years ago

remi-georges commented 4 years ago

and sort dataset et bban structure by their country code

remi-georges commented 4 years ago

I've submitted the same change in this lib : https://github.com/arhs/iban.js/pull/77

remi-georges commented 4 years ago

Library forked here with this update => https://github.com/Paylib-Services/iban4j

arturmkrtchyan commented 4 years ago

Hi @remi-georges,

Would you wish to become a maintainer of the original lib ?

Right now ai have very limited capacity to take care of it.

Let me know.

—Artur

On Mon 23. Mar 2020 at 16:29, remi-georges notifications@github.com wrote:

Library forked here with this update => https://github.com/Paylib-Services/iban4j

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/arturmkrtchyan/iban4j/pull/65#issuecomment-602675142, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAES4LS3RRMGPGTKJZNIW7DRI556RANCNFSM4LF3CXRQ .

kaldebert commented 3 years ago

Hi! Is this possible to accept this PR? I really need this feature on my project.

FrankHossfeld commented 3 years ago

@kaldebert we can add the PR to iban4g if you like. iban4g is based on iban4j. The main difference between both is, that iban4g works with Java, j2cl and GWT. API is the same. What do you think?

hajk1 commented 3 years ago

Hi! Is this possible to accept this PR? I really need this feature on my project.

I will take a look and merge it within a week in case of no conflict.

kaldebert commented 3 years ago

Hello @hajk1, Did you take some time to check and maybe merge this PR? It would be awesome to have this feature in iban4j.

FrankHossfeld commented 3 years ago

@kaldebert: If you like, you can try: https://mvnrepository.com/artifact/com.github.nalukit/iban4g/2.0.2 (which should contain the fix)

In case you find a problem, feel free to contact me.

arturmkrtchyan commented 3 years ago

Hey folks,

I'm happy to add additional maintainers, pls let me know if there is an interest.

--Artur

On Mon, Mar 22, 2021 at 12:23 PM Frank Hossfeld @.***> wrote:

@kaldebert https://github.com/kaldebert: If you like, you can try: https://mvnrepository.com/artifact/com.github.nalukit/iban4g/2.0.2

In case you find a problem, please contact me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arturmkrtchyan/iban4j/pull/65#issuecomment-803987411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAES4LUQN7E65JE5XXISAGLTE4SCXANCNFSM4LF3CXRQ .

FrankHossfeld commented 3 years ago

@arturmkrtchyan you can PM me at Gitter ...

hajk1 commented 3 years ago

Hello @hajk1, Did you take some time to check and maybe merge this PR? It would be awesome to have this feature in iban4j.

Hello, I have reviewed your PR, I found many changes which are not related to your case. Maybe it is related to some formating actions or else. May I ask you to send a separate PR that is just related to your specific subject?

FrankHossfeld commented 3 years ago

Well, it looks like the branch of the PR has made it's own life. As @remi-georges mentioned here:

Library forked here with this update => https://github.com/Paylib-Services/iban4j

So, a simple merge of this branch will not work, cause any other changes done inside this branch get also merge and will break a lot. Also, @remi-georges change the order of the definitions, so it is a little bit harder to identify the changes of the first commit, but not so hard to do.

I think, you need to add the changes by hand.

kaldebert commented 3 years ago

Hi @arturmkrtchyan and @hajk1, You can close this PR, I've done a new one only with the changed code : #84.