search

arturmkrtchyan / iban4j

A Java library for generation and validation of the International Bank Account Numbers (IBAN ISO_13616) and Business Identifier Codes (BIC ISO_9362).
http://iban4j.org
Apache License 2.0
271 stars 124 forks source link

Adding Iban for Egypt (EG) #88

Closed NaveenKumarRajulapati closed 1 year ago

NaveenKumarRajulapati commented 2 years ago

Currently Egypt is using IBAN and we don't have defined that in CountryCode. Because of that we are getting org.iban4j.UnsupportedCountryException: Country code is not supported.

Can we just add Egypt code in the CountryCode class.

FrankHossfeld commented 2 years ago

There is already a PR:

https://github.com/arturmkrtchyan/iban4j/pull/85

NaveenKumarRajulapati commented 2 years ago

Thanks @FrankHossfeld.

Do we have any ETA when we will be merging this.

FrankHossfeld commented 2 years ago

Sorry, no idea. I am not a contributor of this lib.

I have cloned the lib and added/changed a few things and fixed a few bugs. At least I need to change some things to use the lib with GWT/J2CL. Nothing that should have an impact of the way how to use it with Java.

The clone has the same API. And as far as I remember, the IBAN definition of EG is already added.

If you like, you can give it a try: https://github.com/NaluKit/iban4g

NaveenKumarRajulapati commented 2 years ago

Thanks @FrankHossfeld for your support. Let me check it.

bogacaslan commented 1 year ago

I created another PR for this issue, including only required changes:

https://github.com/arturmkrtchyan/iban4j/pull/103