Allow setting a custom Random

arturmkrtchyan / iban4j

A Java library for generation and validation of the International Bank Account Numbers (IBAN ISO_13616) and Business Identifier Codes (BIC ISO_9362).

http://iban4j.org

Apache License 2.0

271 stars 124 forks source link

Closed aSemy closed 11 months ago

aSemy commented 2 years ago

Allow passing in a custom random, so users can make the generation deterministic.

resolves #91

fix spelling mistake in test, ibanContruction -> ibanConstruction
add toString() to BbanStructureEntry.java (this helps the test error messages)
tests to check if randomness is deterministic
add additional tests for validity of BbanStructureEntry.java

[x] I was confused by the EntryCharacterType - need to remove the TODO comment and possibly update the Javadoc

Bas-Boven commented 1 year ago

We are eagerly expecting this improvement. Would love to see it merged!