arturmkrtchyan / iban4j

A Java library for generation and validation of the International Bank Account Numbers (IBAN ISO_13616) and Business Identifier Codes (BIC ISO_9362).
http://iban4j.org
Apache License 2.0
270 stars 124 forks source link

structureOfPLIban #98

Closed mmaciekk111 closed 1 year ago

mmaciekk111 commented 1 year ago

Hi, now bban > BbanStructure > structures.put(CountryCode.PL, new BbanStructure( BbanStructureEntry.bankCode(3, 'n'), BbanStructureEntry.branchCode(4, 'n'), BbanStructureEntry.nationalCheckDigit(1, 'n'), BbanStructureEntry.accountNumber(16, 'n')));

should be: structures.put(CountryCode.PL, new BbanStructure( BbanStructureEntry.bankCode(4, 'n'), BbanStructureEntry.branchCode(3, 'n'), BbanStructureEntry.nationalCheckDigit(1, 'n'), BbanStructureEntry.accountNumber(16, 'n')));

Best, M

FrankHossfeld commented 1 year ago

Looking at the definition here the current implementation seams to be correct?

PLkk bbbs sssx cccc cccc cccc cccc
b = National bank code
s = Branch code
x = National check digit
c = Account number

Can you provide more informations?

mmaciekk111 commented 1 year ago

In the Polish system, bank numbers have 4 digits. Like below: 1010 Narodowy Bank Polski 1020 PKO BP 1030 Bank Handlowy 1050 ING Bank Śląski 1130 Bank Gospodarstwa Krajowego 1140 mBank 1160 Bank Millennium 1240 Pekao SA 1280 HSBC Polska 1320 Bank Pocztowy 1540 BOŚ Bank 1580 Mercedes-Benz Bank 1610 Spółdzielcza Grupa Bankowa 1670 RBS Bank 1680 Plus Bank 1840 Societe Generale SA 1870 Nest Bank 1930 Bank Polskiej Spółdzielczości 1940 Credit Agricole 1950 Idea Bank 2030 BNP Paribas 2070 FCE Bank Polska SA 2120 Santander 2130 Volkswagen Bank 2140 Fiat Bank Polska 2160 Toyota Bank 2190 DNB Bank Polska SA 2480 Getin Bank 2490 Alior Bank

wt., 8 lis 2022, 18:48 użytkownik Frank Hossfeld @.***> napisał:

Looking at the definition here https://en.wikipedia.org/wiki/International_Bank_Account_Number the definition seams correct?

PLkk bbbs sssx cccc cccc cccc cccc

b = National bank code s = Branch code x = National check digit c = Account number

Can you provide more informations?

— Reply to this email directly, view it on GitHub https://github.com/arturmkrtchyan/iban4j/issues/98#issuecomment-1307605875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFWE64Q2VRDDNPULIOUWHDWHKHATANCNFSM6AAAAAAR2LXLAA . You are receiving this because you authored the thread.Message ID: @.***>

FrankHossfeld commented 1 year ago

Please, check this: https://bank.codes/iban/structure/poland/

mmaciekk111 commented 1 year ago

Numer instytucji - bank code ID oddziału - branch code. It is in Polish, you can check on any website.

wt., 8 lis 2022, 20:03 użytkownik Frank Hossfeld @.***> napisał:

Please, check this: https://bank.codes/iban/structure/poland/

I think the fourth digit - in your example - is the first digit from the branch code

— Reply to this email directly, view it on GitHub https://github.com/arturmkrtchyan/iban4j/issues/98#issuecomment-1307694232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFWE66NFDZPXKZRUAWYJZLWHKPZNANCNFSM6AAAAAAR2LXLAA . You are receiving this because you authored the thread.Message ID: @.***>

FrankHossfeld commented 1 year ago

Might be, but I would put my 2 pence on the international standard ...