arturo-lang / arturo-lang.io

The official website for the Arturo programming language
6 stars 4 forks source link

fix: issue #1 @RickBarreto fork and #3 #2

Closed RickBarretto closed 1 year ago

RickBarretto commented 1 year ago

Explanation (Fix #1 @RickBarretto)

As finally a release for Msys2 ocurred, I decided to test it and see if all is alright.

  1. I compared Windows and WindowsMsys2 versions.
    • They are the same, so it's right!
  2. I uninstalled arturo from my machine
  3. I runned sh nightly.sh to see if it's installing
    • But it was not installing
    • It was missing mv command, to move from unpacked folder to bin folder
    • This was working just with msys_fake_download_arturo, because this command was there

What I've done

RickBarretto commented 1 year ago

I tested, it's working now! 😉 @drkameleon. Sorry for my error!

RickBarretto commented 1 year ago

Fix issue #3

Issue: Assume user shell from another beyond /bin/ #3

What I've done

Commit: assume user shell from another paths

My test

$ mkdir ~/test
$ cd ~/test
$ touch abin.sh bin.sh
$ ls *bin.sh
abin.sh bin.sh
$ ls "*bin.sh"
ls: cannot access '*bin.sh': No such file or directory
drkameleon commented 1 year ago

Great job!

The install script is a hybrid between the older installation script (@ arturo repo), only converted to Bash/shell script. Now, the main installation script (build.nims) is written in NimScript and far more advanced than this one. But given that for this particular use-case we needed something simpler and not dependent on Nim at all, I migrated code from the old repo, albeit a tiny bit not-so-well-maintained.

Thanks again! Keep it up! 😉