search

arturo-lang / arturo

Simple, expressive & portable programming language for efficient scripting
http://arturo-lang.io
MIT License
675 stars 29 forks source link

[Net] Use OpenSSL 1.1 in all cases #1578

Open github-actions[bot] opened 4 months ago

github-actions[bot] commented 4 months ago

[Net] Use OpenSSL 1.1 in all cases right now, every OS/architecture statically links OpenSSL 1.1. except for Mac/arm64 (M1). This - most likely - leads to the aforementioned binaries being largest, without any reason. This has to be fixed (by finding the correct libraries to link against and making sure they are found during compilation). Once this is done, we'll also have to remove the definition of --define:useOpenssl3 in .config/buildmode.nims

https://github.com/arturo-lang/arturo/blob/b389a5b9fb3c33b2f43cf079d8661f50e96866e5/src/library/Net.nim#L29

        {.passL: "-Bstatic -Lsrc/extras/openssl/deps/linux -lssl -lcrypto -Bdynamic".}
    elif defined(macosx):
        # TODO(Net) Use OpenSSL 1.1 in all cases
        #  right now, every OS/architecture statically links OpenSSL 1.1.
        #  except for Mac/arm64 (M1). This - most likely - leads to the aforementioned
        #  binaries being largest, without any reason. This has to be fixed (by finding the correct
        #  libraries to link against and making sure they are found during compilation). Once this is
        #  done, we'll also have to remove the definition of `--define:useOpenssl3` in 
        #  .config/buildmode.nims
        #  labels: enhancement, 3rd-party, macos
        when defined(arm64):
            {.passL: "-Bstatic -Lsrc/extras/openssl/deps/macos/m1 -lssl -lcrypto -Bdynamic".}
        else:
            {.passL: "-Bstatic -Lsrc/extras/openssl/deps/macos -lssl -lcrypto -Bdynamic".}

#=======================================
# Libraries
ndex af3506075e..6496a2b76c 100644
++ b/src/vm/values/custom/vregex.nim

4914a5ab1aff1b512eae867238f16a18e53d9eb1