Inconsistent behavior of `between?`-related unit-test

arturo-lang / arturo

Simple, expressive & portable programming language for efficient scripting

http://arturo-lang.io

MIT License

697 stars 32 forks source link

Inconsistent behavior of `between?`-related unit-test #1667

Open drkameleon opened 1 month ago

drkameleon commented 1 month ago

Describe the bug

The bug has to do with this: https://github.com/arturo-lang/arturo/blob/master/tests/unitt/lib/comparison/between.test.art#L43-L64

At times, it breaks some of our CI runs, and mostly it doesn't. One way to "solve" it would be to complete comment it out.

But, obviously, that's not the way... So, let's fix it!

@RickBarretto Any ideas here?

RickBarretto commented 1 month ago

@drkameleon the only solution that comes in my mind is to use a smaller limit and use the max function. I guess this is an issue with number overflowing.

At least, when I was creating this test, I noticed there was some occasions that this error occurred.

drkameleon commented 2 weeks ago

@RickBarretto Quite a few occasions... I keep coming across this thing all the time 🫤

Again: https://github.com/arturo-lang/arturo/actions/runs/10644402527/job/29509120649