[Helpers/unisort] Re-visit & test digraph/trigraph sorting

github-actions[bot] commented 2 years ago

The code below - apparently - works ok. The problem is: a) it hasn't been thoroughly tested, b) it looks obviously too repetitive, c) it must be the most inefficient code written on Earth

https://github.com/arturo-lang/arturo/blob/ce734e7a32c73173910cdf8f533f56be21febe3b/src/helpers/unisort.nim#L128


    if ngraphset == @[]:
        # TODO(Helpers/unisort) Re-visit & test digraph/trigraph sorting
        #  The code below - apparently - works ok. The problem is: a) it hasn't been thoroughly tested, b) it looks obviously too repetitive, c) it must be the most inefficient code written on Earth
        #  labels: helpers, enhancement, cleanup
        while i < x.s.len and j < y.s.len:
            fastRuneAt(x.s, i, xr)
            fastRuneAt(y.s, j, yr)
ndex c999f6c67..fb2c1b3eb 100644
++ b/src/helpers/url.nim

8dd38040a89dd07348e002b963f60c06f61b50a1

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

Closing issue as stale.

stale[bot] commented 1 year ago

Closing issue as stale.

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 days ago

Closing issue as stale.

arturo-lang / arturo

[Helpers/unisort] Re-visit & test digraph/trigraph sorting #609