search

arturoc / gstreamer1.0-rs

Idiomatic bindings for Gstreamer on Rust.
MIT License
36 stars 14 forks source link

ElementT.play(), pause(), etc should return the correct value #8

Closed sdroege closed 8 years ago

sdroege commented 8 years ago

Currently they return bool or nothing. However it is very important that you handle the return values correctly. Especially ASYNC/NO_PREROLL should not be just considered SUCCESS but might require special handling inside the application.

And all state changes can fail, not returning anything is a problem.

arturoc commented 8 years ago

i've added GstStateChangeReturn to anything that changes the element state but let me know if you think it should be somewhere else.

thanks!

sdroege commented 8 years ago

Thanks, looks complete to me. But I'm currently not using your bindings in an application, I was just looking at the status of the bindings and how the GStreamer API could look like in Rust.

sdroege commented 8 years ago

Btw, are there any public projects you're aware of that are using the bindings?

arturoc commented 8 years ago

i don't know of any, i've received some pull requests so i suppose some people is using it but don't know of any project that it's using it