arturoc / nvidia-texture-tools

Automatically exported from code.google.com/p/nvidia-texture-tools
Other
0 stars 0 forks source link

Patch submission: BMP file loading support and new nvcompress options. #128

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Apologies if there is another way for me to submit a patch.

Whilst BMP is an antiquated format, many artists still insist to continue using 
it. This patch handles loading most BMP variations (all except 1bit).

I understand you'd like to keep nvcompress simple and as an example, but it 
really is a useful command line tool. The compress.cpp file contains code for 
these new options:

-high      Enable highest quality compression
-box       Use MipmapFilter Box
-triangle  Use MipmapFilter Triangle
-kaiser    Use MipmapFilter Kaiser

Original issue reported on code.google.com by roond...@gmail.com on 8 Jul 2010 at 4:45

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch! If you are using svn, the easiest way to generate a patch 
that can be merged automatically is with this command:

svn diff > nvimage.patch

but I for this one it should be easy to merge the changes manually. At first 
glance your changes look good. However, I'm extremely busy right now, getting 
ready to move to Spain for a month, but I should be able to integrate this next 
week, or hopefully sooner.

Original comment by cast...@gmail.com on 13 Jul 2010 at 11:07

GoogleCodeExporter commented 8 years ago
You're welcome, thanks for your work on the great tool :)

Please use attached ImageIO.cpp rather than the one in the rar archive. I 
somehow neglected to test some of the BMP types after adding the padPerLine 
changes. This resulted in completely incorrect 24 bit bitmap loading. No hurry 
integrating this patch by the way, but it'd be nice if it was in some future 
release though :)

Unfortunately my employer doesn't allow me to connect to external svn, but as 
you say, it should be pretty easy to integrate.
-Aranda

Original comment by roond...@gmail.com on 14 Jul 2010 at 3:18

Attachments:

GoogleCodeExporter commented 8 years ago
good job for the bmp support, I will integrate this in my project :-)

my own version of loadBmp only support 24bit and 32bit bmps for simplicity.

thank u

Original comment by wuyu....@gmail.com on 23 Aug 2011 at 12:32