search

arturoc / ofxGStreamer

openFrameworks addon to use gstreamer under osx and windows. This addon has no code and instead uses the addon_config.mk file to add the needed files from the core + the flags needed to compile using gstreamer
56 stars 28 forks source link

osx: ADDON_SOURCES += src/ofxGStreamer.h #4

Closed vdonnefort closed 9 years ago

vdonnefort commented 9 years ago

What's the purpose of these lines? 

ADDON_SOURCES += src/ofxGStreamer.h
ADDON_SOURCES += src/ofxGStreamer.cpp

It breaks the ofxGstreamer build:

make[1]: *** No rule to make target `/Users/vdonnefort/Workspace/openFrameworks/addons/obj/osx/Release/ofxGstreamer/src/ofxGStreamer.h'

AFAIK, it is not necessary since src/ folder is parsed when building the addon

arturoc commented 9 years ago

there was a problem with the makefiles in the last fix but i think it should be ok now, i'm going to close it but let me know if you still have problems

vdonnefort commented 9 years ago

If think you're talking about this commit: https://github.com/openframeworks/openFrameworks/commit/70994ff88945813c6984d583c5132d704a40e808

It indeed fixes the error. However, I have now the following problem:

fatal error: 'ofxGStreamer.h' file not found

If I look at the c++ commands which fails, it is missing something like:

-I/Users/xxxxxx/openFrameworks/addons/ofxGStreamer/src/
arturoc commented 9 years ago

can you check if my last commit to the OF repository fixes it?

arturoc commented 9 years ago

btw, those files are needed to set the correct paths if you want to compile the application as standalone without needing to install gstreamer in the system. it only works in osx right now

vdonnefort commented 9 years ago

Sadly it doesn't fix my problem.

Here's the complete commands which fails: https://gist.github.com/vdonnefort/366ef0cca7e821a2e7bb

I only have into my app:

$ cat addons.make
ofxGStreamer

and the include:

#include <ofxGStreamer.h>
arturoc commented 9 years ago

ok, i've finally managed to test it on osx, that last commit to OF master fixes it for me but let me know if it's still problematic

vdonnefort commented 9 years ago

I still have a problem:

openFrameworks/libs/openFrameworksCompiled/project/makefileCommon/config.addons.mk:159: *** cannot find addon source file ../../../libs/openFrameworks/video/ofGstUtils.h.

It may be linked to this line from config.addons.mk:

$(if $(filter $(addon)%, $(addon_src)),

Where

$(addon) = /Users/vdonnefort/Workspace/openFrameworks/addons/ofxGStreamer
$(addon_src) = ../../../libs/openFrameworks/video/ofGstUtils.h

Do we need to add $(OF_ADDONS_PATH) to the $(addon_src) to compare 2 absolute paths?

arturoc commented 9 years ago

oh, yeah sorry should be ok now

vdonnefort commented 9 years ago

Nope, still the same error:

cannot find addon source file ../../../libs/openFrameworks/video/ofGstUtils.h

What I understand is $(OF_ROOT) is an absolute path and $(addon_src) is a relative one. That's why the Makefile filter function fails, isn't it?

Before this commit https://github.com/openframeworks/openFrameworks/commit/b80089f5ea80fce6294ee0ec1f1c6e65ea67e96a, there were checks for absolute/relative path using wildcards here. What about them?