search

artursapek / mondrian

Web-based vector graphics editor
MIT License
1.24k stars 104 forks source link

Color picker should constrain colors to the visible window #18

Closed waldyrious closed 10 years ago

waldyrious commented 10 years ago

If I drag the handle too far left, I get black; if I drag it upwards or downwards (outside the colored square) I get hues that aren't represented in the square. It's not an intuitive behavior; the handle should be constricted to the square color area.

artursapek commented 10 years ago

You're right. I would even consider this a bug. The dragging outside of the picker should be ignored.

wraybowling commented 10 years ago

I disagree! This is one of the more wonderful and beautiful features of Mondrian. If there is any bugginess to it, it is only that going past white makes black. Don't nerf a genuinely unique idea just because one person didn't like it.

artursapek commented 10 years ago

Oh, I just meant the horizontal overflow, where you get black after going off white.

Getting different hues when you go off vertical is not a bug. In fact that's how you change the hue - you scroll vertically. No way I'm removing that, I think it's awesome.

waldyrious commented 10 years ago

Don't nerf a genuinely unique idea just because one person didn't like it.

FWIW I don't dislike it, actually I think it is a neat feature too! I was just unsure it was intended, so I mentioned it together with the jumping-to-black bug, just in case, since they seemed to be driven by the same code.

artursapek commented 10 years ago

I think people will generally scroll until the hue they want is in the middle of the color picker, so the vertical over-dragging isn't really a problem. The same thing horizontally is definitely a bug.

Thanks for the reports, @waldir. Much appreciated.