artursapek / mondrian

Web-based vector graphics editor
MIT License
1.24k stars 104 forks source link

Show tooltips when hovering the tool icons #20

Closed waldyrious closed 10 years ago

Fishrock123 commented 10 years ago

:+1:

artursapek commented 10 years ago

:+1:, this would be a great addition.

artursapek commented 10 years ago

Aesthetically,

More importantly, they should be abstracted so that they're easy to change in a tool's config. Eg a tool should have a hotkey key, and a name key that populate the tooltip. So for tools.pen, that would look like:

  name: "Pen"
  hotkey: "p"

Currently tools don't define their own hotkeys - they are hard-coded here. Ideally it would work how menu items work, where they define their own hotkey and the class takes care of listening to it. I never got around to refactoring the tools to work the same way, so this is a good opportunity to do that.

Fishrock123 commented 10 years ago

As discussed via Email: I'm taking this up.

Yes, I had found the hotkeys class, and had wondered if class-defined hotkeys wouldn't be better.

Eventually, it would probably be best to have rebindable keys. Perhaps we can have one interface where the tools initially bind themselves to a key, and then settings are loaded, rebinding them as the user defines.

Fishrock123 commented 10 years ago

@artursapek So as I understand it, these are duplicates and should be removed?

artursapek commented 10 years ago

Yes, user-customized bindings shouldn't be hard to implement. Not really a priority for now, though. The hotkeys are pretty standard and memorable (many of them even match Illustrator's).

And I do think those are duplicates. Just try removing them and see if those functions break, the app will give you a more definite answer than me :)