Refactor hotkeys & add tool icon tooltips.

artursapek / mondrian

Web-based vector graphics editor

MIT License

1.24k stars 104 forks source link

Refactor hotkeys & add tool icon tooltips. #33

Closed Fishrock123 closed 10 years ago

Fishrock123 commented 10 years ago

[x] Refactors hotkeys into respective tool files.
[x] Removed duplicate / unused hotkeys.
[x] Adds description tooltips to each tool icon.
~~Refactor Menus and Tools to propagate from class files?~~ (nah - https://github.com/artursapek/mondrian/pull/33#discussion_r9332400)

Will close #20.

(The reason I bundled these together is that tooltips would have depended on some of the new hotkey things. Since we are not refactoring them at this time, however, that is not the case.)

Fishrock123 commented 10 years ago

@artursapek - Where are the tool icons added in the code? Can't seem to find it. :/

artursapek commented 10 years ago

They're hard-coded right now, in index.html

Fishrock123 commented 10 years ago

@artursapek LGTY?

Fishrock123 commented 10 years ago

6d084e7 refers to https://github.com/artursapek/mondrian/issues/13#issuecomment-33862238

artursapek commented 10 years ago

It's a good start, but it's too slow. And once a tooltip is open, moving the cursor to the next tool button should immediately show its tooltip. This will let people scan the tools quickly. Having to wait that long each time is maddening.

I'm making some changes to address that and I'll ship this.

Fishrock123 commented 10 years ago

Ok, sounds good. :+1:

artursapek commented 10 years ago

You can see my changes here. Pull it, play with it, tell me what you think. I want to refactor all the logic into a new tooltips file before I merge it, but the I think the behavior is good.