Update appcache per-build & untrack.

artursapek / mondrian

Web-based vector graphics editor

MIT License

1.24k stars 104 forks source link

Update appcache per-build & untrack. #41

Closed Fishrock123 closed 10 years ago

Fishrock123 commented 10 years ago

Untracking built app cache. Revision is now a number. SHA and Date for reference.

May it be said that I despise node's way of doing file read / write operations.

I might end up moving the git SHA stuff into it's own module. Seems useful enough.

Refers to #37 and https://github.com/artursapek/mondrian/issues/13#issuecomment-34120230.

Fishrock123 commented 10 years ago

(I'm not sure if this fully fixes #37 or not. But I guess this is a good first step at least.)

artursapek commented 10 years ago

Hey, this looks solid. I'll test it tonight and merge if I don't find any problems.

Fishrock123 commented 10 years ago

There is a slight possibility between branches that have it tracked right now and ones that won't that there will be a rough transition where you could end up building with the same number more than once. We could just set the build revision as the unix time when it was built, or hash the date or something.

i.e. appcache will still cause problems, just less so. Not sure its worth bothering with it.

artursapek commented 10 years ago

Awesome work. +1. Merged.