search

arturzx / homeassistant-iqua-softener

Home assistant integration for iQua app supported water softeners
MIT License
35 stars 13 forks source link

Feature Request: Water Shutoff Option #16

Open awlynn68 opened 2 months ago

awlynn68 commented 2 months ago

Some of the softeners support an optional water shutoff valve feature. Could the presence, state and control of the valve be added to this integration?

mikedhanson commented 3 weeks ago

please

wash3re commented 3 weeks ago

The basic code exists, but someone needs to put it in. My skills are not remotely good enough to do it, but someone probably can! I wish they would.

mikedhanson commented 3 weeks ago

Ill take a crack at it.

awlynn68 commented 3 weeks ago

I can test it as I installed the feature in my system.

demonspork commented 1 week ago

Ill take a crack at it.

You get anywhere with it? I spent some time today digging and i realized the work on a different fork to group everything as a device is huge improvement and it might make sense to start from there. https://github.com/briis/homeassistant-iqua-softener Not sure why he hasn't made a PR yet to merge those changes.

I've also got the valve installed to test with and may give it a shot myself in the near future. Haven't done any work in HA python code since the project started though.

mikedhanson commented 1 week ago

Funny you ask. Been working on it as we speak.

image

I was also going to add a refresh interval to it. image

mikedhanson commented 1 week ago

Ran into some issues, would love some help with this.

demonspork commented 1 week ago

Ran into some issues, would love some help with this.

Create a fork and publish what you have

mikedhanson commented 1 week ago

https://github.com/mikedhanson/homeassistant-iqua-softener

Here are my changes.

The main thing that I could not figure out is how the integration downloads the code from iqua-softener to use the iqua.py

I hope someone can get this working.

demonspork commented 1 week ago

Home Assistant handles the dependency by the manifest.json where requirements can be specified. iqua-softener is published on pypi and home assistant will automatically acquire it on launch.

A core problem might be that the published version doesn't include the water valve code yet. I think we need @arturzx to publish a new version of the iqua-softener package to fix this fully, or include the iqua-softener manually. https://pypi.org/project/iqua-softener/#history

I'll see if I can sit down and test this out this weekend. It has been several years since I did any code work in home assistant, so no guarantees I can figure it out. I may just have to resign myself to writing a quick script that directly uses the iqua-softener to make it happen.