Closed fairking closed 2 months ago
@fairking great find! Also thanks for creating a PR, will review ASAP
Please consider to remove white spaces when compare changes: https://github.com/chrispahm/chartjs-plugin-dragdata/pull/82/commits/480c8aded35d840a717a8b159406770d832c7e26?diff=unified&w=1
Hi @fairking, as the new maintainer, I wanted to pick this one up. Certainly, the changes you suggest would solve the issue, yet AFAIK they are not officially supported (the docs state that the shape of a data point for the floating bar chart should [number, number]
). Anyway, since supporting that doesn't come at any cost and chart.js's floating bar controller source also does not seem to prevent this, I will take a look into it.
Since in the meantime there have been numerous changes and your PR also includes some unrelated things, I will just apply your suggestions in a new PR.
If additional data passed to the chart they being removed on drag and the chart not considered as a
floatingBar
.samplePoint.length >= 2
:data
argument is not used in code: