search

artus9033 / chartjs-plugin-dragdata

Draggable data points plugin for Chart.js
MIT License
266 stars 56 forks source link

Project rewrite in typescript #86

Closed artus9033 closed 8 months ago

artus9033 commented 2 years ago

As this is a helpful project, I gave it a rewrite in typescript so as to support type annotations and make the code base a bit easier to be maintained. For now, a few lines that rely on Chart.js's typings are ignored with // @ts-ignore and these need to be overriden with declare module - I created an example overide for the plugin's options as well. Compilation has not changed much, still uses rollup with typescript plugin, and emits typings to dist as well. Of course, all tests still pass. Please feel free to verify whether it's okay to be merged.

chrispahm commented 2 years ago

Sorry I didn't get to review this yet, but it looks great!

artus9033 commented 2 years ago

@chrispahm will you review this PR for a possible merge?

akkitheakhil commented 1 year ago

I would really appreciate it if this PR could be reviewed and merged.

artus9033 commented 1 year ago

@chrispahm can you report any progress regardin the review of this PR?

chrispahm commented 1 year ago

Hey I'm sorry for taking so long, I don't work with Chart.js anymore so this work just comes on top of the other things... If someone's interested to maintain this repo (maybe @artus9033?) please write me a short mail (see profile)!

Note that there are still a lot of test cases missing (see #40), plus there are no unit test at all! This is the main reason why I started lagging behind all these PRs and issues, as all options need to be tested manually after each update. Maybe Github Copilot / ChatGPT could be of help writing these test but I wouldn't be too sure about it...

artus9033 commented 1 month ago

Now resolved in #146 🎸