artusjs / core

Core package of Artus
MIT License
210 stars 16 forks source link

fix(scanner): use individual store for loadConfigItemList #248

Closed noahziheng closed 1 year ago

noahziheng commented 1 year ago

scanner/utils 中的 loadConfigItemList 方法用于在扫描每个 Ref 时加载其内部的配置,为了保证函数类型配置工作正常,此前复用了 app,但此前仅在扫描任务完全结束时清理了一次 ConfigStore,所以可能在某些 ref 中拿到被不正常合并后的配置,造成加载异常。

本 PR 调整项包括:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (4688317) 91.72% compared to head (7cce44b) 91.71%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #248 +/- ## ========================================== - Coverage 91.72% 91.71% -0.01% ========================================== Files 49 49 Lines 1196 1195 -1 Branches 214 212 -2 ========================================== - Hits 1097 1096 -1 Misses 99 99 ``` | [Impacted Files](https://app.codecov.io/gh/artusjs/core/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artusjs) | Coverage Δ | | |---|---|---| | [src/configuration/index.ts](https://app.codecov.io/gh/artusjs/core/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artusjs#diff-c3JjL2NvbmZpZ3VyYXRpb24vaW5kZXgudHM=) | `70.58% <ø> (-3.10%)` | :arrow_down: | | [src/scanner/task.ts](https://app.codecov.io/gh/artusjs/core/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artusjs#diff-c3JjL3NjYW5uZXIvdGFzay50cw==) | `95.38% <ø> (-0.04%)` | :arrow_down: | | [src/scanner/utils.ts](https://app.codecov.io/gh/artusjs/core/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artusjs#diff-c3JjL3NjYW5uZXIvdXRpbHMudHM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.