artutra / OpenChord

A React Native songbook app for guitar players
GNU General Public License v3.0
146 stars 24 forks source link

Create custom chords #115

Open artutra opened 4 years ago

faniry6 commented 4 years ago

As given here https://www.chordpro.org/chordpro/Directives-define.html one can define chord manually in the chordpro file. But I guess you thought about editing manually the chord svg by moving the dots?

One thing I do not have any idea how to solve is the transpose problem. Should it be transposed?

artutra commented 4 years ago

First, no, I believe that the custom chord should not be transposed. If the song is transposed it will show the chords from the database again until you customise the new transposed chord.

About SVG, I intend to create an UI for every metadata of the chordpro specification (such as capo, tunning, tempo, custom chord definition, etc) so, to create a custom chord specification you should:

I am still creating a button to import .chordpro files on the Settings tab, but after I complete it, we should look for the best way to parse the chordpro text and extract the custom chords from it

faniry6 commented 4 years ago

Having these features would be amazing 😁