artyfacialintelagent / CloneCleaner

An extension for Automatic1111 to work around Stable Diffusion's "clone problem". It automatically modifies your prompts with random names, nationalities, hair style and hair color to create more variations in generated people.
MIT License
96 stars 7 forks source link

Conflict with the Dynamic Prompts extension #1

Open OliverTempel opened 1 year ago

OliverTempel commented 1 year ago

Settings: Batch Count: 10 Positiv Prompt: RAW photo, best quality, high resolution), a perfect photo of a woman

Expected: 10 differtent Prompts: Patricia from Uganda, (short-cut:1.2) bob-cut hair, RAW photo, best quality, high resolution), a ... Riley from Hong Kong, medium (shoulder-length:1.2) grown-out pixie-cut hair, RAW photo, best quality, high resolution), a ... ...

Got: Patricia from Uganda, (short-cut:1.2) bob-cut hair, RAW photo, best quality, high resolution), a ... Patricia from Uganda, (short-cut:1.2) bob-cut hair, RAW photo, best quality, high resolution), a ... ...

Gwynei commented 1 year ago

Can confirm.

artyfacialintelagent commented 1 year ago

Unfortunately I can't reproduce this on my system. [EDIT: caused by an extension conflict, see comment below] I get different random tokens for each image whether I use batch count or batch size. It would be great if both of you could help me with more diagnostics:

Thanks and sorry about the problem!

OliverTempel commented 1 year ago

Version-Info: version: [v1.4.0](https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/394ffa7b0a7fff3ec484bcd084e673a8b301ccc8)   python: 3.10.7 torch: 2.0.1+cu118   xformers: N/A   gradio: 3.32.0 checkpoint: [bfea7e18e2](https://google.com/search?q=bfea7e18e236471741f96ad5e987f214eb31ac75a923ca6ff0ef883d5d15f85e)

OS: windows 10 pro

Extensions:

https://files.catbox.moe/7rz3o2.zip https://files.catbox.moe/yqygiv.zip

OliverTempel commented 1 year ago

i think i could help you with this error, disabled all extensions and enabled extension for extension and check if the error came back.

as soon as i enable "sd-dynamic-prompts" error came back.

So please fix it as soon as possible. "sd-dynamic-prompts" is a very important extension :)

songib commented 1 year ago

yeah, I got the same issue atm. fix seed or random seed didn't solve the problem. some people already mention "sd-dynamic-prompts", so probably using some exception to works similar like Adetailer with this exclusion "dynamic_prompting,dynamic_thresholding,wildcard_recursive,wildcards"

IDK much about programming stuff. so yeah. xd Same seed sd-dynamic-prompts is Enable grid-0001 sd-dynamic-prompts is Disable grid-0002

GalaxyTimeMachine commented 1 year ago

I have the same problem when using "Dynamic Prompts" extension.

artyfacialintelagent commented 1 year ago

Thanks everyone for reporting. I can reproduce the problem and can confirm that there is indeed a conflict with the Dynamic Prompts extension. Apparently that extension only reads the prompt from the first image of a batch. CloneCleaner works by modifying the individual prompts of a batch, and works correctly even when Dynamic Prompts is enabled. However, since DP runs after CloneCleaner (extensions run in alphabetical order I believe), DP clobbers the prompt changes that CloneCleaner has made.

Unfortunately that means that there is no way I can fix the conflict myself, but I will open an issue for Dynamic Prompts and ask them to play nice with other extensions (by reading all prompts instead of just the first of a batch).

So this means it is not yet possible to run CloneCleaner and Dynamic Prompts simultaneously, so you will have to enable/disable them depending on which you prefer to run for any given prompt. Once DP addresses the underlying issue the extensions should be compatible though, fingers crossed.