Replace std::auto_ptr in the public part of API with std::unique_ptr.

ghost commented 2 years ago

As we know, std::auto_ptr was deprecated in C++11 and fully removed in C++17. While it is still possible to build CppCMS without using C++17, std::auto_ptr uses in the public part of API causing compilation errors if C++17 is a must. That's why, in the current form, there is no way to use CppCMS alongside C++17 header-only libraries.

In order to fix this problem, we can replace std::auto_ptr with std::unique_ptr in all public header files (i.e., the files which are installed into include/ dir). Then, we can proceed with replacement until the codebase can be compiled without any compilation errors.

In this patch, following steps are followed:

Prune std::auto_ptr from public header files.
Modify private header files and declaration in source files to match public part.
Modify function/template implementation and preprocessor macros until all compilation errors eliminated.
After modifications, run tests again to ensure there is no illegal pointer dereferencing.

ghost commented 2 years ago

Apparently, it is already replaced in v2.0.0.* development. So, this patch is redundant and obsolete.

artyom-beilis commented 2 years ago

Exactly :-)

I need to release 2.0.0 ASAP

masaoliou commented 2 years ago

The upside with good old auto_ptr is that I can compile cppcms::json using C++Builder 6. I will retain a copy of version 1 for a long while.

artyom-beilis / cppcms

Replace std::auto_ptr in the public part of API with std::unique_ptr. #92