Do not apply udev-monitor-set-timeout! to #f values.

artyom-poptsov / guile-udev

GNU Guile bindings to libudev.

GNU General Public License v3.0

7 stars 3 forks source link

Do not apply udev-monitor-set-timeout! to #f values. #9

Closed Apteryks closed 10 months ago

Apteryks commented 10 months ago

This is a follow-up to commit 980fe40, which changed the default timeout-sec and timeout-usec values to #f, with the behavior of waiting indefinitely for an event.

modules/udev/monitor.scm (make-udev-monitor): Filter out arguments whose values are #f.

Apteryks commented 10 months ago

I think I'll want to revisit this fix; but I don't have an immediate solution.

One problem I see is that if someone specifies #:timeout-sec #f and #:timeout-usecs 100, the udev-monitor-remove-filters! procedure would now be called with usecs as secs, silently.

I think I should handle #f values in udev-monitor-remove-filters! in C.