search

aruZeta / QRgen

A QR code generation library.
https://aruzeta.github.io/QRgen/
MIT License
103 stars 8 forks source link

Feature: more intuitive radius (SVG) #23

Closed aruZeta closed 2 years ago

aruZeta commented 2 years ago

I think it's very unintuitive to have the the radius parameters be an absolute size instead of a percentage, like 60%, 40%, etc. At least for SVGs, where rx will always be a value from 0 to 0.4 for modules since it's a vector.

I'm not making the commit directly to develop since I want to know what you guys think about this.

Mainly @enthus1ast @EyeCon @tandy-1000

aruZeta commented 2 years ago

Will have to fix the that action.

aruZeta commented 2 years ago

That did the trick

tandy-1000 commented 2 years ago

This makes sense to me :) Thank you.

aruZeta commented 2 years ago

I will wait till enthusiast shares his opinion on this, and also I would like to ask if this should be released to 2.0.0 or 1.1.0, I don't know if this is actually breaking backwards compatibility or not (I mean, it breaks rounded SVGs written before this PR, but is it that huge of a break? I'm trying to follow https://semver.org/).

And also the same goes to the SVG class names changes.

enthus1ast commented 2 years ago

Much better! When I understand semver correctly it should be a major version change.

aruZeta commented 2 years ago

Okay then I will merge this into develop and next release will be 2.0.0.

Main breaking changes will be (for the moment):