search

aruba / pyedgeconnect

Python wrapper for Aruba Orchestrator and Edge Connect API
MIT License
14 stars 9 forks source link

Fix #8: ID as query parameter instead of path in _delete() #9

Closed wrgeorge1983 closed 8 months ago

wrgeorge1983 commented 9 months ago

8

Currently the URL given is incorrect like this:

return self._delete(
    "/gms/appliance/preconfiguration/{}".format(preconfig_id),
    return_type="bool",
)

this is incorrect and results in this error:

[DELETE] /gms/appliance/preconfiguration/8 | Received HTTP 404 | Response text: null for uri: http://hostname.silverpeak.cloud/gms/rest/gms/appliance/preconfiguration/8?source=menu_rest_apis_id

inspecting orchestrator API calls, it should be like so:

return self._delete(
    "/gms/appliance/preconfiguration/?preconfigId={}".format(preconfig_id),
    return_type="bool",
)
zachcamara-hpe commented 8 months ago

This was handled in the 0.16.0 release, this PR couldn't be accepted given more complex requirement of maintaining backwards compatibility with pre-9.3 changes to Orchestrator API