Updated example/config.yml with default "hourly" parameter.

aruhier / virt-backup

Backup your kvm guests managed by libvirt

Other

107 stars 23 forks source link

Updated example/config.yml with default "hourly" parameter. #26

Closed sanminaben closed 4 years ago

sanminaben commented 4 years ago

Leaving the "hourly" parameter unspecified in a group will lead to all backups being kept on every "clean" pass, regardless of their daily/weekly/monthly/yearly parameters. It took me a while to figure out that the problem was that the group I had created did not specify "hourly". If "hourly" is specified in defaults as "1", at least when not specifying it in individual groups it won't affect the cleanup of backups.

coveralls commented 4 years ago

Coverage remained the same at 79.383% when pulling 514decc6fa71e307f4e649104abbbffbbc6694a2 on sanminaben:master into 3d1ebf0315ecec02308239845050e242a5f2f6d1 on aruhier:master.

aruhier commented 4 years ago

Hi @sanminaben, Thanks for this PR. I will also open an issue to fix this behavior when a parameter is not specified, as it seems indeed really weird for the user.

sanminaben commented 4 years ago

Thanks for the merge!