adds sha1 hash to json - Githubissues

aruhier / virt-backup

Backup your kvm guests managed by libvirt

Other

106 stars 23 forks source link

adds sha1 hash to json #42

Open hruljov opened 3 years ago

hruljov commented 3 years ago

coveralls commented 3 years ago

Coverage decreased (-0.8%) to 82.633% when pulling e1426fb80bcb692561018b40dfbd6d7f5b686075 on hruljov:master into bbcf5607ba00eebe443b2396f0b646191b3150c2 on aruhier:dev.

aruhier commented 3 years ago

Hi, Thanks a lot for your PR!

However I have an issue with the fact that each image disk will be read twice. I'm wondering if it would not be better to compute the hash in the packagers, when adding a file. The packagers could return a hash as a result.

hruljov commented 3 years ago

Need to look at the functional packagers