search

aruhier / virt-backup

Backup your kvm guests managed by libvirt
Other
107 stars 23 forks source link

Match domains by UUID #43

Closed arkadiam closed 3 years ago

arkadiam commented 3 years ago

For all non-active domains .ID() returns the same -1.

aruhier commented 3 years ago

Nice catch. Can you also change to the UUID comparison in backups/snapshot:_pivot_callback() please?

I'm also wondering if the domain_id field in the definition shouldn't be changed to UUID instead of ID…

arkadiam commented 3 years ago

Thanks for your feedback. I'll update _pivot_callback shortly....

If we'll change domain_id too, we'll have very long backup filenames. I'd leave is as is for now. I don't mind -1 in the name...

arkadiam commented 3 years ago

Please take a look again.

aruhier commented 3 years ago

Perfect, thanks a lot!