search

aruhier / virt-backup

Backup your kvm guests managed by libvirt
Other
106 stars 23 forks source link

guard against simultaneous clean runs #49

Closed henkrs closed 1 year ago

henkrs commented 1 year ago

When multiple clean group jobs start on several machines at the same time and they all use the same file system for storage, file names might exist in the global list that had vanished in the meantime and the 'open' call will raise a FileNotFoundError exception breaking the loop. Let's log a warning and continue processing.

aruhier commented 1 year ago

Thanks a lot for your PR, that's indeed a nice change. I just have a small request over the warning message to make it clearer.

henkrs commented 1 year ago

Sure, we can change that. What do you suggest?

aruhier commented 1 year ago

Sorry I forgot to submit the review…

henkrs commented 1 year ago

Well, there you go.

aruhier commented 1 year ago

Thanks a lot!

henkrs commented 1 year ago

You too mate.

Anthony Ruhier wrote:

Thanks a lot!

-- Reply to this email directly or view it on GitHub: https://github.com/aruhier/virt-backup/pull/49#issuecomment-1413562325 You are receiving this because you authored the thread.

Message ID: @.***>

Henk

-- Centrum Wiskunde & Informatica Science Park 123, 1098 XG Amsterdam