aruizs / unleash-client-cpp

C++ client SDK for Unleash, an open-source feature flag management service.
MIT License
11 stars 5 forks source link

Add constraint evaluation to maintained strategies #32

Open bolomcs50 opened 8 months ago

bolomcs50 commented 8 months ago

@aruizs I noticed some strategies are implemented in such a way that they do not process associated constraints. I believe this is due to strategies having changed in v5.x, as per the documentation, correct me if I am wrong. My understanding of that documentation is that the remoteaddress, flexiblerollout and applicationhostnames (respectively called in v5 "IPs", "Gradual Rollout" and "Hostnames") should indeed evaluate constraints. The standard strategy already correctly evaluates them. I would also argue that these changes would not break compatibility with any existing software: if one designs a strategy without constraints, then the code behaves exactly as it did before.