search

arumoy-shome / UWNerdist

Got free time? Check out what classes are going on at the UW campus that interest you!
MIT License
1 stars 1 forks source link

Pull request template #39

Closed vishalbabu closed 7 years ago

vishalbabu commented 7 years ago

Closes issue #38: Testing Pull request method. What else are you looking for in this template

arumoy-shome commented 7 years ago

Thanks for taking this up! Here is what we can add for the PR template for the time being:

Thanks for the PR! Here are a few things you should consider mentioning in your description:

* Which issue (if any) does this PR concern? (bonus points for writing in format that closes the issue once PR merges!)
* Why was this change necessary?
* How does it address the problem?
* Are there any side effects?

One problem with the PR, GitHub took up your previous commit for the doc update in here as well. Ah, seems like the doc update PR was opened from your master branch, and since you branched off master for this PR, your previous commit was included in here as well. 😄

Can you remove the previous commit from here? You will have to do a git reset and remove the changes you made in CONTRIBUTING.md. I would also close the other PR you have and push in a new one from another branch, I hope it's not too big of a deal?