search

arumoy-shome / UWNerdist

Got free time? Check out what classes are going on at the UW campus that interest you!
MIT License
1 stars 1 forks source link

Resetting pr #49

Closed vishalbabu closed 6 years ago

vishalbabu commented 7 years ago

Resetting previous changes to CONTRIBUTING.md so a proper merge can occur.

arumoy-shome commented 7 years ago

Nice! Can you address the changes I had requested in #35?

arumoy-shome commented 7 years ago

@vishalbabu I think you forgot to include the new FAQ doc that contains your note in the PR? Can you push it up so we can 🚀 this PR?

arumoy-shome commented 7 years ago

Looking good, however there is nothing that links to the new doc that you just created. We should try to make it easier for others to find it, I suggest we add a link to the FAQ doc on the main README file. It should probably be somewhere in the setup section.

Since the doc is markdown you can style it, I have left some comments. Come to think of it, I don't think I have any guidelines on how to write docs so perhaps we should add that? @vishalbabu would you mind opening up an issue for it? We can discuss and develop the guide in the issue once you open it. 😄

arumoy-shome commented 7 years ago

@vishalbabu this PR has been stale for a while, any updates on this?

vishalbabu commented 7 years ago

@arumoy-shome I just did an update on the repo and my FAQ.md doc is not on under the docs folder anymore. Think this issue can be closed for now.

arumoy-shome commented 7 years ago

Huh that's weird, are you on your local branch? You won't see the file if you are on master since we didn't merge your PR yet.