image url problem

[fthamura]

I see the image::blabla.png is direct to the wrong location

it should be https://github.com/javaee-samples/docker-java/blob/master/chapters/images/plain-wildfly0.png

became

https://github.com/javaee-samples/docker-java/blob/master/chapters/plain-wildfly0.png

these affects to all the adoc that contain image

[arun-gupta]

The correct way to read the document is: https://htmlpreview.github.io/?https://github.com/javaee-samples/docker-java/blob/master/readme.html

Wondering if @mojavelinux has any clues about how to solve it?

[fthamura]

if you see the image, all still missing

F

Frans Thamura (曽志胜) Java Champion Shadow Master and Lead Investor Meruvian. Integrated Hypermedia Java Solution Provider.

Mobile: +628557888699 Blog: http://blogs.mervpolis.com/roller/flatburger (id)

FB: http://www.facebook.com/meruvian TW: http://www.twitter.com/meruvian / @meruvian Website: http://www.meruvian.org

"We grow because we share the same belief."

On Sun, Sep 6, 2015 at 10:42 PM, Arun Gupta notifications@github.com wrote:

The correct way to read the document is: https://htmlpreview.github.io/?https://github.com/javaee-samples/docker-java/blob/master/readme.html

Wondering if @mojavelinux https://github.com/mojavelinux has any clues about how to solve it?

— Reply to this email directly or view it on GitHub https://github.com/javaee-samples/docker-java/issues/87#issuecomment-138094190 .

[arun-gupta]

Image links are fixed in HTML: https://htmlpreview.github.io/?https://github.com/javaee-samples/docker-java/blob/master/readme.html

Links are still broken in adoc. May be @mojavelinux have any some suggestions>

[mojavelinux]

The trick is to define the imagesdir at the top of each file if it isn't otherwise set. Here's what you've done in other documents that worked well.

ifndef::imagesdir[:imagesdir: images]

What I like about this approach is that it allows you to set the value globally when running the asciidoctor command and not have it be overridden. Another way of writing it that sometimes works (depends on how you invoke asciidoctor is)

:imagesdir: images@

I kind of think the first approach is safer, esp for your usage.