search

arun-gupta / microservices

Java EE and Microservices
629 stars 381 forks source link

Snoop version implemented #32

Closed ivargrimstad closed 9 years ago

ivargrimstad commented 9 years ago

This fixes arungupta/microservices#21

Since I had to make small changes in the everest app to test the integration through snoop, I did this in a separate branch.

ivargrimstad commented 9 years ago

You're right. The data-source element in the persistence.xml files does not need to be there. For some reason Wildfly complained when I did not have it there. Should not be needed. Just forgot to remove it from the commit.

The @EnableSnoopClient annotation can stay even if the server is not running. It will log that it tried to connect and failed though.

arun-gupta commented 9 years ago

Can you amend the PR?

ivargrimstad commented 9 years ago

The log will look like this if the snoop-service is not running: 19:22:50,006 CONFIG [eu.agilejava.snoop](EJB default - 7) Sending message: {"applicationName":"order","applicationHome":"http://localhost:8080/order/resources","applicationServiceRoot":"order"} 19:22:50,015 WARNING [eu.agilejava.snoop](EJB default - 3) Connection refused

arun-gupta commented 9 years ago

Can you add a Snoop container as well?

ivargrimstad commented 9 years ago

I pushed one to docker hub today called ivargrimstad/snoop-service https://registry.hub.docker.com/u/ivargrimstad/snoop-service/

The latest war is also available in my nexus (running on openshift of course :)) http://nexus.agilejava.eu/nexus/index.html#nexus-search;quick~snoop-service

arun-gupta commented 9 years ago

Add the instructions to the doc here?

arun-gupta commented 9 years ago

Thanks a lot @ivargrimstad, now merged!

ivargrimstad commented 9 years ago

Brilliant! Had great fun :)

arun-gupta commented 9 years ago

Refactored the code as well, and I think its much cleaner now.

ivargrimstad commented 9 years ago

Looks great!