search

arun11299 / cpp-jwt

JSON Web Token library for C++
MIT License
395 stars 111 forks source link

fix: algorithm::NONE string representation capitalized, tests linkage fixes #66

Closed nikita-karatun closed 4 years ago

nikita-karatun commented 4 years ago

Hi! Faced problems with compiling and running tests.

  1. ${GTest_LIBRARIES} appears to be empty on my OS (Linux Mint 19.3), seems to be case-sensitivity issue, fixed by linking against GTest::GTest GTest::Main, also linking against GTest::Main makes main method manually placed in every test redundant.
  2. Also case-sensitivity issue. test_jwt_encode test wouldn't pass, judging by the assert (line 120), it expects algorithm::NONE to be serialized in capital letters which won't happen. I capitalized algorithm::NONE string representation ('NONE') label, which seems logical from my perspective, since all other algorithms are capitalized.
arun11299 commented 4 years ago

Thanks for contribution!

nikita-karatun commented 4 years ago

Thank you!