search

arun11299 / cpp-subprocess

Subprocessing with modern C++
Other
449 stars 90 forks source link

memory leak #103

Closed jsho000 closed 2 weeks ago

jsho000 commented 4 months ago

In the following code:

      int read_bytes = util::read_atmost_n(
                                  fdopen(err_rd_pipe, "r"),
                                  err_buf,
                                  SP_MAX_ERR_BUF_SIZ);
      close(err_rd_pipe);

The value returned by fdopen() is not closed. This causes memory leak. If you call fclose(), it will close err_rd_pipe. So close(err_rd_pipe) is not necessary.

arun11299 commented 2 weeks ago

@jsho000 Thank you for reporting. Can you provide a PR after testing the required changes ?

arun11299 commented 2 weeks ago

Will be fixed with https://github.com/arun11299/cpp-subprocess/issues/104