arun11299 / cpp-subprocess

Subprocessing with modern C++
Other
456 stars 90 forks source link

Fix lto build on clang by marking HolderBase::operator() as abstract #12

Closed DarkDimius closed 6 years ago

DarkDimius commented 6 years ago

Otherwise errors such as

bin/watchman/libwatchman.a(watchman.pic.o):(.data+0x30e48): undefined reference to `typeinfo for subprocess::preexec_func::HolderBase'
bin/watchman/libwatchman.a(watchman.pic.o):(.data+0x31e28): undefined reference to `typeinfo for subprocess::preexec_func::HolderBase'

are reported

arun11299 commented 6 years ago

Thanks @DarkDimius !!