arun11299 / cpp-subprocess

Subprocessing with modern C++
Other
456 stars 90 forks source link

Add virtual destructor to HolderBase #28

Closed jvilk-stripe closed 5 years ago

jvilk-stripe commented 5 years ago

Adds an empty virtual destructor to HolderBase. Avoids undefined behavior.

"Deleting a derived class object using a pointer to a base class that has a non-virtual destructor results in undefined behavior."