search

arun11299 / cpp-subprocess

Subprocessing with modern C++
Other
456 stars 90 forks source link

some functions are not inline #43

Open klosworks opened 5 years ago

klosworks commented 5 years ago

Some functions are not inline. This will cause multiple definition errors in projects that include your lib. Examples:

  std::string get_last_error()
  FILE *file_from_handle(HANDLE h, const char *mode)
void configure_pipe(HANDLE* read_handle, HANDLE* write_handle, HANDLE* child_handle)

There is already an issue https://github.com/arun11299/cpp-subprocess/issues/34, but it is about a specific function and you have a more general problem.

deanmsands3 commented 3 years ago

Submitted Pull Request #59 .