search

arun11299 / cpp-subprocess

Subprocessing with modern C++
Other
449 stars 90 forks source link

string comparison issue on win32 #55

Closed wolfv closed 4 years ago

wolfv commented 4 years ago

There is a char* == "w" here:

https://github.com/arun11299/cpp-subprocess/blob/f1a698b50e53e34db17e730c259cb60f023ccff2/subprocess.hpp#L239-L244

which never seems to succeed. Instead, using strcmp(mode, "w") == 0 works as expected.

arun11299 commented 4 years ago

@wolfv Thanks for reporting. Would you like to provide a pull request for it ?