Allow use json 2.x versions

arunagw / omniauth-twitter

OmniAuth strategy for Twitter

http://arunagw.github.io/omniauth-twitter/

578 stars 167 forks source link

Closed Fudoshiki closed 7 years ago

connorshea commented 8 years ago

Need to lock rack to 1.x for versions prior to Ruby 2.2, should also probably test the gem on Ruby 2.3. json 2.x requires Ruby 2.0+.

Maybe worth dropping Ruby 1.9 and 2.0 support as well, as both are EOL.

connorshea commented 8 years ago

Oh, and the reason for allowing json 2.x is that json 1.x doesn't currently support Ruby 2.4.

Alternatively we could just drop the json gem entirely, as was done here and here.

SamSaffron commented 7 years ago

yes ... please drop it altogether ❤️

arunagw commented 7 years ago

I have prepared #113. Please have a look.

arunagw commented 7 years ago

I think we are good with #114 now.