arunavabasucom / radis-app

A web app for high-resolution infrared molecular spectra using RADIS
https://radis.app
GNU Lesser General Public License v3.0
11 stars 16 forks source link

Integrating GEISA databank in the Radis Interface #570

Closed arunavabasucom closed 2 years ago

arunavabasucom commented 2 years ago

Description: This pull request Integrate GEISA databank in the Radis App interface

Hey @suzil, @erwanp, please give some feedback . Description Deadline Status
ui changes to select the geisa (deafult : "hitan") 18 May Completed
fetch the data from geisa 18 May Completed
download the molecule from hitran 18 May Inprogress
download the molecule from geisa 18 May Inprogress
arunavabasucom commented 2 years ago

Updated :

https://user-images.githubusercontent.com/73842340/169034125-66247992-6c37-4b5e-81d1-d59dfd36631a.mp4

erwanp commented 2 years ago

Hello @arunavabasu-03 , can we have ""Databank" [btw, we could rename the label "Database" , it's more common] and "Mode" [absorbacne etc.] share the same first line ?

Could be "Databank" on the left ; "Mode" on the right.

erwanp commented 2 years ago

Excellent video above; well done for checking it still worked in reduced-width !

Seems good for me

arunavabasucom commented 2 years ago

@suzil @erwanp, any extra thing I have to take care of.

erwanp commented 2 years ago

Agreed on the rename, for labels ! Only warning : keep databank= in calc_spectrum (python) (and probably the mirror CalcSpectrum ) as it's the RADIS API

arunavabasucom commented 2 years ago

hey @suzil @erwanp, I rename the labels.