arunavabasucom / radis-app

A web app for high-resolution infrared molecular spectra using RADIS
https://radis.app
GNU Lesser General Public License v3.0
11 stars 15 forks source link

Adding Simulate slit #610

Closed arunavabasucom closed 2 years ago

arunavabasucom commented 2 years ago

Add slit as a field so that users may apply it as they want !!

suzil commented 2 years ago

I think the UI might be a bit confusing for users when they don't want to simulate a slit as right now they would have to leave the textfield with no value.

Screen Shot 2022-07-19 at 3 08 25 PM

I wonder if a better UI setup could be to use a "simulate slit" switch to ask the user whether or not they want to simulate a slit, and if the user activates the switch, then a new text field appears that prompts them for how big the slit should be.

Thoughts here @arunavabasu-03 @erwanp?

arunavabasucom commented 2 years ago

@suzil, slider, or switch ??

suzil commented 2 years ago

Sorry I meant switch! I'll edit the original message to prevent more confusion.

erwanp commented 2 years ago

Agreed with suzil.

Also, deactivate the option if in Absorbance mode. There is a slit only in Radiance or Transmittance

erwanp commented 2 years ago

Btw i'm noticing a small glitch image

arunavabasucom commented 2 years ago

@suzil , @erwanp done

suzil commented 2 years ago

@arunavabasu-03 In the future, would you write your commits according to this style guide? https://cbea.ms/git-commit/

Right now I'm trying to track when our frontend stopped running locally and some of the commit messages make it more difficult for me to go through the history and know what's going on because the commit messages are too vague.

arunavabasucom commented 2 years ago

@suzil done

suzil commented 2 years ago

I want to run the backend locally to test the changes made to both the frontend and the backend, but I'm having this bug with GEISA: https://github.com/radis/radis/issues/497 HITRAN is unfortunately offline (also yesterday), so I'm not able to really test the changes as those are our only two DBs.

suzil commented 2 years ago

I would have the simulate slit amount appear below the switch so that the user filling out the form works in a single direction (down).

https://user-images.githubusercontent.com/13723264/181255968-41556b04-6c94-45d7-a2b1-08a607a03224.mov

erwanp commented 2 years ago

Hello, couple suggestinos :

Can you also make the Slit size input box appear on the right of the Switch ? , or, if it doesn't work well, below the switch ?

arunavabasucom commented 2 years ago

@erwanp, check !!

Screenshot 2022-07-28 at 9 37 54 PM